feat: Add Route Groups [WIP] #13148
Open
feat: Add Route Groups [WIP] #13148
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
CodSpeed Performance ReportMerging #13148 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This aims to add Route Groups, as known from Next.js and requested here: withastro/roadmap#480
Folder names in (parenthesis) should be excluded from the route structure, but their content should not be.
This can especially be helpful with boilerplates to encapsulate some of the logic.
Testing
Some tests should be added for sure. I had a quick look at packages/astro/test/route-manifest.test.js but they are all commented out.
I did some quick manual testing to check that it works as expected, however can't rule out that there have been major oversights since I didn't dig trough the whole codebase.
Docs
Docs should be added for this, probably a small passage in https://docs.astro.build/en/guides/routing/
As this this should not clash with any existing route logic, this could hopefully be kept rather short